Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P0] Revert back the kwargs argument for intervention init #166

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

frankaging
Copy link
Collaborator

Description

Recent SAE change causes a regression for some existing tests. This change tries to fix the issue by reverting back some code change.

Testing Done

Running existing tests.

Checklist:

  • My PR title strictly follows the format: [Your Priority] Your Title
  • I have attached the testing log above
  • I provide enough comments to my code
  • I have changed documentations
  • I have added tests for my changes

@frankaging frankaging merged commit b3f6c2a into main Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant