Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P1] Add IntervenableModel.named_parameters() #122

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

aryamanarora
Copy link
Collaborator

@aryamanarora aryamanarora commented Mar 1, 2024

Description

This adds the named_parameters() method which is used by HF trainer to find the trainable parameters to pass to the optimiser (#121).

Testing Done

No effect on any existing code.

Checklist:

  • My PR title strictly follows the format: [Your Priority] Your Title
  • I have attached the testing log above
  • I provide enough comments to my code
  • I have changed documentations
  • I have added tests for my changes

@frankaging frankaging merged commit 35a3433 into stanfordnlp:main Mar 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants