Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P1] Add intervention util unit tests #100

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[P1] Add intervention util unit tests #100

merged 2 commits into from
Jan 31, 2024

Conversation

ZhengPeterWang
Copy link
Collaborator

@ZhengPeterWang ZhengPeterWang commented Jan 31, 2024

Description

Add intervention utils unit tests

Testing Done

Testing VanillaIntervention, CollectIntervention, BoundlessRotatedSpaceIntervention

Checklist:

  • My PR title strictly follows the format: [Your Priority] Your Title
  • I have attached the testing log above
  • I provide enough comments to my code
  • I have changed documentations
  • I have added tests for my changes

Copy link
Collaborator

@frankaging frankaging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankaging frankaging merged commit 344bd7d into main Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants