Initial contact center base scenario setup and added summarization scenario #2569
Conversation
first summarization scenarios
| sampling_min_length: Optional[int] = None, | ||
| sampling_max_length: Optional[int] = None, | ||
| doc_max_length: Optional[int] = None, |
There was a problem hiding this comment.
suggestion: names like
doc_filter_min_length, doc_filter_max_length, doc_truncation_max_length
or
filter_doc_min_length, filter_doc_max_length, truncate_doc_max_length
or
doc_filter_min_words, doc_filter_max_words, doc_truncation_max_words
would be more self-evident.
| sampling_min_length will be filtered out. | ||
| Useful for preventing the adapter from sampling | ||
| really small documents. | ||
| sampling_max_length: Int indicating maximum length for training |
There was a problem hiding this comment.
change comments to indicate that "length" is the number of words, not characters (or change the variable names to reflect this)
| self.dataset_path = dataset_path | ||
| self.sampling_min_length = sampling_min_length | ||
| self.sampling_max_length = sampling_max_length | ||
| self.doc_max_length = doc_max_length |
There was a problem hiding this comment.
This doesn't seem to be used. Are you missing the truncation logic? Alternatively, just delete this parameter.
| Scenario for contact center conversational summarization. | ||
| """ | ||
|
|
||
| name = "cc_convo_summarization" |
There was a problem hiding this comment.
Pick a consistent name that is used both here and as the filename. I'd prefer both to be contact_center_conversation_summarization, but I'd also be fine with both being cc_convo_summarization.
Likewise with the other file.
| name = "cc_conversation" | ||
| description = "Base scenario for contact center conversation tasks" | ||
| tags = ["cc_conversation"] |
There was a problem hiding this comment.
You can just delete name, description and tags since this is not a concrete class and can't be instantated.
No description provided.