Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sierpinski triangle #25

Closed
wants to merge 2 commits into from
Closed

Sierpinski triangle #25

wants to merge 2 commits into from

Conversation

rmeertens
Copy link
Contributor

I created a 3D sierpinski triangle in your christmas tree. The added file is a simulator.

@oliverdunk
Copy link
Member

Hey @rmeertens! Matt asked if I could help with maintaining this repository, so I've been thinking about how best to do that. I've decided to create an examples folder where we can add contributions like this one - you can find some more information in the README.

Would you be up for updating your PR, to move your effect in to the examples folder, and also remove the simulator file? It would be really nice to get a sierpinski triangle merged.

@rmeertens
Copy link
Contributor Author

@oliverdunk Thanks a lot for maintaining the repository! I created the new pull request here: #26. Let me know if anything should be changed :)

Also, to be honest: I would like to have a simulator in the final repo, if only to enjoy the examples other people added to the repository. Might be something to consider :)

@oliverdunk
Copy link
Member

Amazing, thanks! Will close this one out in favour of that one.

Totally agree about simulators. #5 seemed like a simple one so I commented there and am hoping we can get it merged. If not, I may pick another! Feel free to open a PR which adds a link to yours in the README, would be great if people could find it :)

@oliverdunk oliverdunk closed this Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants