Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 'universal' binaries on MacOS #1483

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Documentation
    • OR, no user-facing changes were made

Release notes

The MacOS binaries we distribute are now 'universal' (fat) binaries, and therefore will not require Rosetta to run.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@WardBrian
Copy link
Member Author

@WardBrian WardBrian marked this pull request as ready for review January 3, 2025 17:42
Copy link
Contributor

@serban-nicusor-toptal serban-nicusor-toptal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WardBrian WardBrian merged commit f0c0ebd into master Jan 6, 2025
11 checks passed
@WardBrian WardBrian deleted the macos-universal-binary branch January 6, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants