Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Selectively initialize SoA types" #1376

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Documentation
    • If a user-facing facing change was made, the documentation PR is here:
    • OR, no user-facing changes were made

Release notes

Reverted #1323 as stan-dev/math#2978 provides a better solution at a lower level.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #1376 (a80ac26) into master (7b69a19) will decrease coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1376      +/-   ##
==========================================
- Coverage   89.93%   89.93%   -0.01%     
==========================================
  Files          63       63              
  Lines       10704    10699       -5     
==========================================
- Hits         9627     9622       -5     
  Misses       1077     1077              
Files Coverage Δ
src/analysis_and_optimization/Optimize.ml 93.23% <66.66%> (-0.07%) ⬇️

@WardBrian WardBrian marked this pull request as ready for review December 1, 2023 12:57
@WardBrian WardBrian merged commit 992ff90 into master Dec 1, 2023
2 checks passed
@WardBrian WardBrian deleted the fix/revert-1323 branch December 1, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants