-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/reduce mem pathfinder #3325
Open
SteveBronder
wants to merge
19
commits into
develop
Choose a base branch
from
feature/reduce-mem-pathfinder
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
87be301
Pathfinder lazily evaluates and writes parameters instead of taking e…
SteveBronder 3c932f0
add docs
SteveBronder f1a8e56
remove stringstream from unique stream writer
SteveBronder 48bbb6e
update laplace
SteveBronder 0b46b4a
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot c644df0
remove newline
SteveBronder 814f8df
fixing pathfinder return results
SteveBronder e484fa1
adds concurrent queue so writes are thread safe to one file
SteveBronder e88ca19
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot 6b24bbf
fix docs for multi_stream_writer
SteveBronder 0e48078
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot 298761e
fix docs for multi_stream_writer
SteveBronder ae3740c
fix docs for multi_stream_writer
SteveBronder b98f60f
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot a18d7e9
update normal_glm test for better inits
SteveBronder 9250e76
Merge remote-tracking branch 'refs/remotes/origin/feature/reduce-mem-…
SteveBronder 4a058bc
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot 09d66e5
update headers
SteveBronder c25ec46
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I like these overloads --
writer
Separately, isn't
std::ostream
buffered internally anyway?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to introduce state directly in the class
I totally missed this. Yeah my through was that having a little buffer we reuse would save some memory, but idt it's worth the overhead of config etc. And we only use it for the case of a std vector really