Merge pull request #3294 from stan-dev/fix/model-header-include-order

Fix model_header include order when STAN_MODEL_FVAR_VAR is defined
stan-dev · Jul 10, 2024 · 7e76f26 · 7e76f26
2 parents 3c95657 + 343eebb
commit 7e76f26
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 5 deletions.
diff --git a/src/stan/model/model_base.hpp b/src/stan/model/model_base.hpp
@@ -1,11 +1,11 @@
 #ifndef STAN_MODEL_MODEL_BASE_HPP
 #define STAN_MODEL_MODEL_BASE_HPP
 
-#include <stan/io/var_context.hpp>
-#include <stan/math/rev/core.hpp>
 #ifdef STAN_MODEL_FVAR_VAR
 #include <stan/math/mix.hpp>
 #endif
+#include <stan/io/var_context.hpp>
+#include <stan/math/rev/core.hpp>
 #include <stan/model/prob_grad.hpp>
 #include <stan/services/util/create_rng.hpp>
 #include <ostream>

diff --git a/src/stan/model/model_base_crtp.hpp b/src/stan/model/model_base_crtp.hpp
@@ -1,10 +1,10 @@
 #ifndef STAN_MODEL_MODEL_BASE_CRTP_HPP
 #define STAN_MODEL_MODEL_BASE_CRTP_HPP
 
-#include <stan/model/model_base.hpp>
 #ifdef STAN_MODEL_FVAR_VAR
 #include <stan/math/mix.hpp>
 #endif
+#include <stan/model/model_base.hpp>
 #include <iostream>
 #include <utility>
 #include <vector>

diff --git a/src/stan/model/model_header.hpp b/src/stan/model/model_header.hpp
@@ -1,14 +1,14 @@
 #ifndef STAN_MODEL_MODEL_HEADER_HPP
 #define STAN_MODEL_MODEL_HEADER_HPP
 
+#include <stan/model/model_base.hpp>
+#include <stan/model/model_base_crtp.hpp>
 #include <stan/math.hpp>
 
 #include <stan/io/deserializer.hpp>
 #include <stan/io/serializer.hpp>
 
 #include <stan/model/rethrow_located.hpp>
-#include <stan/model/model_base.hpp>
-#include <stan/model/model_base_crtp.hpp>
 #include <stan/model/prob_grad.hpp>
 #include <stan/model/indexing.hpp>
 #include <stan/services/util/create_rng.hpp>

diff --git a/src/test/test-models/good/model/accumulate.stan b/src/test/test-models/good/model/accumulate.stan
@@ -0,0 +1,9 @@
+data {
+  int<lower=1> N;
+}
+parameters {
+  vector[N] y;
+}
+model {
+  target += y;
+}
diff --git a/src/test/unit/model/compile_test.cpp b/src/test/unit/model/compile_test.cpp
@@ -0,0 +1,2 @@
+// test model which previously failed with -DSTAN_MODEL_FVAR_VAR
+#include <test/test-models/good/model/accumulate.hpp>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		// test model which previously failed with -DSTAN_MODEL_FVAR_VAR
		#include <test/test-models/good/model/accumulate.hpp>