Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #156 #269

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Fix issue #156 #269

merged 2 commits into from
Jan 24, 2022

Conversation

fweber144
Copy link
Collaborator

This fixes issue #156.

a smooth term with multiple predictors. The reason is that `nitro` and `bv` measure different things (unlike spatial coordinates, for example) and `s()` uses a thin plate regression spline by default (which is *isotropic*).
@AlejandroCatalina AlejandroCatalina merged commit ce3b2fd into stan-dev:develop Jan 24, 2022
@fweber144 fweber144 deleted the issue156_fix branch January 24, 2022 19:20
@fweber144
Copy link
Collaborator Author

Thanks for merging this. Just for the sake of completeness: I forgot to mention the following remarks which might become relevant when support for additive models is extended:

  • I merged the "population-level interaction smoothers" into the "interaction smoothers" because to me, they appeared to be the same.
  • In the t2() (formerly te()) term, I omitted argument bs because of what is described in issue Documentation of formula for additive models #156. Btw, I think this argument bs can be omitted in the demonstration anyhow because its default is "cr" and that should be the typical use case. (Compared to cubic regression splines, thin plate regression splines don't have an advantage as marginal bases for tensor product smooths (see ?mgcv::smooth.terms) and they are computationally more expensive.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants