Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix use of ceiling in ps_tail_length #383

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix use of ceiling in ps_tail_length #383

merged 1 commit into from
Nov 7, 2024

Conversation

avehtari
Copy link
Collaborator

@avehtari avehtari commented Nov 7, 2024

Use of ceiling() for both conditions in ps_tail_length

Fixes #382

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@avehtari avehtari requested a review from n-kall November 7, 2024 10:12
n-kall
n-kall approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@n-kall n-kall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paul-buerkner
Copy link
Collaborator

Great! Merging then.

@paul-buerkner paul-buerkner merged commit 4166286 into master Nov 7, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-kall n-kall n-kall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

posterior_khat gives wrong result if S<225 and S/5 not an integer
3 participants
@avehtari @paul-buerkner @n-kall