Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pareto smoothing weights test #335

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

n-kall
Copy link
Collaborator

@n-kall n-kall commented Jan 10, 2024

Summary

Minor fix to test for log weight pareto smoothing

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@paul-buerkner
Copy link
Collaborator

Thanks.

@paul-buerkner paul-buerkner merged commit 0322b46 into stan-dev:master Jan 10, 2024
9 of 10 checks passed
Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if a6ed9ef is merged into master:

  •   :ballot_box_with_check:as_draws_array: 105ms -> 105ms [-1.35%, +0.43%]
  •   :ballot_box_with_check:as_draws_df: 32.5ms -> 32.6ms [-1.4%, +1.86%]
  •   :ballot_box_with_check:as_draws_list: 193ms -> 193ms [-2.46%, +2.48%]
  •   :ballot_box_with_check:as_draws_matrix: 32.3ms -> 32.1ms [-2.31%, +0.67%]
  •   :ballot_box_with_check:as_draws_rvars: 159ms -> 161ms [-1.13%, +3.81%]
  •   :ballot_box_with_check:summarise_draws_100_variables: 724ms -> 726ms [-1.03%, +1.35%]
  •   :ballot_box_with_check:summarise_draws_10_variables: 79.2ms -> 79.8ms [-0.67%, +2.16%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants