-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overload matrix multiplication operator for rvars in R >= 4.3 #320
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
==========================================
- Coverage 95.60% 95.52% -0.08%
==========================================
Files 47 47
Lines 3686 3691 +5
==========================================
+ Hits 3524 3526 +2
- Misses 162 165 +3 ☔ View full report in Codecov by Sentry. |
The one missing line in code coverage probably can't be tested until they add more generics to The check failures I am fixing now. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if bc26835 is merged into master:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7bc98df is merged into master:
|
This should be ready now; the test failure in R 3.6 looks to be unrelated. |
Looks good. Thank you! |
Summary
As promised on bluesky (hah), since in R >= 4.3 you can now implement
%*%
for S3 classes, this PR allows you to use%*%
instead of%**%
for matrix multiplying rvars.There are also some minor maintenance things in there: it bumps to a dev version, adds that section in news, and re-documents.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: