Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-reference rename_variables and set_variables #316

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

avehtari
Copy link
Collaborator

Cross-reference rename_variables and set_variables in See also sections

Summary

Please describe the purpose of the pull request.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:
Aki Vehtari

Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7404035 is merged into master:

  •   :rocket:as_draws_array: 103ms -> 101ms [-2.98%, -0.05%]
  •   :ballot_box_with_check:as_draws_df: 32.6ms -> 33.2ms [-0.61%, +4.33%]
  •   :ballot_box_with_check:as_draws_list: 193ms -> 192ms [-5.86%, +4.93%]
  •   :ballot_box_with_check:as_draws_matrix: 29.9ms -> 29.5ms [-3.1%, +0.79%]
  •   :ballot_box_with_check:as_draws_rvars: 163ms -> 163ms [-3.13%, +3.17%]
  •   :ballot_box_with_check:summarise_draws_100_variables: 724ms -> 721ms [-1.2%, +0.33%]
  •   :ballot_box_with_check:summarise_draws_10_variables: 79.9ms -> 81.1ms [-1.03%, +3.93%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@paul-buerkner
Copy link
Collaborator

Thanks!

@paul-buerkner paul-buerkner merged commit c6ab463 into master Nov 17, 2023
9 of 10 checks passed
@jgabry jgabry deleted the doc-improvements branch November 17, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants