Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #311

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Create CONTRIBUTING.md #311

merged 1 commit into from
Nov 10, 2023

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Nov 9, 2023

Adds CONTRIBUTING.md based on the tidyverse contributing guidelines

@codecov-commenter
Copy link

Codecov Report

Merging #311 (3fb442c) into master (60dbbe9) will not change coverage.
The diff coverage is n/a.

❗ Current head 3fb442c differs from pull request most recent head fc68364. Consider uploading reports for the commit fc68364 to get more accurate results

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          47       47           
  Lines        3686     3686           
=======================================
  Hits         3524     3524           
  Misses        162      162           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

github-actions bot commented Nov 9, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3fb442c is merged into master:

  •   :ballot_box_with_check:as_draws_array: 104ms -> 103ms [-1.48%, +0.93%]
  •   :ballot_box_with_check:as_draws_df: 32.5ms -> 32.5ms [-2%, +2.09%]
  •   :ballot_box_with_check:as_draws_list: 191ms -> 193ms [-0.55%, +2.33%]
  •   :rocket:as_draws_matrix: 33.2ms -> 29.8ms [-17.58%, -2.45%]
  •   :ballot_box_with_check:as_draws_rvars: 164ms -> 161ms [-4.69%, +0.89%]
  •   :ballot_box_with_check:summarise_draws_100_variables: 720ms -> 715ms [-1.78%, +0.22%]
  •   :ballot_box_with_check:summarise_draws_10_variables: 79.8ms -> 79.9ms [-0.91%, +1.37%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@paul-buerkner
Copy link
Collaborator

Looks good to me. Thanks! Do you want to make any changes before merging?

@jgabry
Copy link
Member Author

jgabry commented Nov 10, 2023

Looks good to me. Thanks! Do you want to make any changes before merging?

Thanks. I think it's good to go. Will merge now.

@jgabry jgabry merged commit 17dd2a3 into master Nov 10, 2023
9 of 10 checks passed
@jgabry jgabry deleted the contributing branch November 10, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants