Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN test fixes for rvar on R 4.4 #305

Merged
merged 3 commits into from
Oct 30, 2023
Merged

CRAN test fixes for rvar on R 4.4 #305

merged 3 commits into from
Oct 30, 2023

Conversation

mjskay
Copy link
Collaborator

@mjskay mjskay commented Oct 30, 2023

Summary

This is a handful of minor fixes for rvar on R 4.4, and closes #304. All of these fixes address slight changes in the handling of dimnames or function arguments in R 4.4 and have no meaningful impact on functionality.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #305 (2c101ff) into master (6add3e6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2c101ff differs from pull request most recent head b8f7da1. Consider uploading reports for the commit b8f7da1 to get more accurate results

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          47       47           
  Lines        3682     3683    +1     
=======================================
+ Hits         3520     3521    +1     
  Misses        162      162           
Files Coverage Δ
R/rvar-bind.R 98.73% <100.00%> (ø)
R/rvar-math.R 100.00% <100.00%> (ø)
R/rvar-slice.R 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2c101ff is merged into master:

  •   :ballot_box_with_check:as_draws_array: 138ms -> 138ms [-0.74%, +0.22%]
  •   :ballot_box_with_check:as_draws_df: 48ms -> 48.5ms [-0.08%, +1.95%]
  •   :ballot_box_with_check:as_draws_list: 253ms -> 252ms [-0.98%, +0.45%]
  •   :ballot_box_with_check:as_draws_matrix: 43.2ms -> 42.6ms [-2.67%, +0.02%]
  •   :ballot_box_with_check:as_draws_rvars: 230ms -> 230ms [-1.14%, +1.49%]
  •   :ballot_box_with_check:summarise_draws_100_variables: 955ms -> 955ms [-0.39%, +0.38%]
  •   :ballot_box_with_check:summarise_draws_10_variables: 106ms -> 106ms [-1.4%, +1.02%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@paul-buerkner
Copy link
Collaborator

Thank you so much for you fixing these issues so quickly!

@paul-buerkner paul-buerkner merged commit 7868fcf into master Oct 30, 2023
9 of 10 checks passed
@mjskay
Copy link
Collaborator Author

mjskay commented Oct 30, 2023

no problem!

@mjskay mjskay deleted the issue-304 branch October 30, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRAN checks on R devel failing
3 participants