Fix usages of fabs in check_symmetric with llvm17 #2991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue found in llvm17 (really libc++ 17, clang version seems to not be the important factor) which broke argument-dependent-lookup of the
fabs
function.So far as I can tell, the only place we were depending on this that could actually get
std::complex
inputs is incheck_symmetric
.To be completely honest, I'm not sure why this specific change fixes the issue, or if there is something better.
Reminder: we probably should not be using
std::complex
in Stan Math!Tests
I added some tests, but because this is in a bleeding edge compiler they won't make much of a difference immediately. They will be run in the next bleeding edge pipeline run.
Side Effects
I don't believe so
Release notes
Fixed a compilation issue with the
check_symmetric
function on complex-valued inputs under LLVM 17Checklist
Copyright holder: Simons Foundation
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested