Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Row-Vector Distribution test failures #2954

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

andrjohns
Copy link
Collaborator

Summary

@WardBrian pointed out that the distribution tests have been failing since #2784 was merged. This was because I'd assumed that only std::vector<int> types would be passed as the vectorised form for int, but the distribution tests also pass Eigen::RowVector int types.

This PR updates the handling of the bernoulli CDF functions to make sure that dimensionality is not assumed.

Tests

N/A

Side Effects

N/A

Release notes

Fix distribution test failures with row-vector integer inputs to bernoulli CDF functions

Checklist

  • Math issue #(issue number)

  • Copyright holder: Andrew Johnson

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just started https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FMath/detail/PR-2954/2/pipeline and manually enabled the row vector tests that get run on develop, so if that passes this should be good!

Thanks for being so quick on this!

@WardBrian WardBrian linked an issue Sep 30, 2023 that may be closed by this pull request
@andrjohns andrjohns merged commit 42bc0c1 into develop Oct 1, 2023
@andrjohns andrjohns deleted the fix-bernoulli-dist-tests branch October 1, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Bernoulli (LC)CDF Numerical Stability
2 participants