-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Tools for testing identities #1677
[WIP] Tools for testing identities #1677
Conversation
…gs/RELEASE_500/final)
…gs/RELEASE_500/final)
…gs/RELEASE_500/final)
…gs/RELEASE_500/final)
…stable/2017-11-14)
…ect_near_rel_improvements
…stable/2017-11-14)
…stable/2017-11-14)
Will move the log_sum_exp to a separate branch later
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
@martinmodrak you have an open testing pull request, so I'm gonna take that as an opening to ask -- do you have any interest in helping us figure out the test framework stuff that needs to come along with the static matrix stuff that @SteveBronder is leading (I don't want to call static matrices but we don't have another name for it yet)? Also we should probably be passing matrix expression types to all our functions as well: stan-dev/design-docs#23 ? Also I remember when we discussed this last we talked about test-framework for vars only. That also would be really useful for complicated interfaces like the variadic ODEs, but also even for development of all the static matrix stuff it'll be nice to get compile errors that don't have more than just |
@bbbales2 Sorry, I am a bit underwater with other commitments right now, so I won't be moving forward on any Stan development at least until the fall (unless something I need for my models crops up). |
@martinmodrak no problem, good luck with your stuff! |
@martinmodrak and @bbbales2, I'm marking this as WIP and closing it for now. Please feel free to reopen later. |
Summary
A simple tool to help write tests involving identities.
Tests
TODO
Side Effects
None
Checklist
Math issue Tools for testing identitites #1671
Copyright holder: Institute of Microbiology of the Czech Academy of Sciences
By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested