Cleanup of "using stan::math::x" and "using stan::x" for non-ambiguous functions #1155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is another slam-dunkish PR to cleanup some of the old issues. I am running some performance/tuning tests and have some downtime to go through this easy stuff.
This PR removes the using statements for the following non-ambiguous functions:
The remaining using statements in
stan/math
are either in theEigen
namespace or for the followingTests
/
Side Effects
/
Checklist
Math issue Remove stan:: namespace qualification #594 and Remove unnecessary using statements from vectorized functions #426
Copyright holder: Rok Češnovar, Univ. of Ljubljana
the basic tests are passing
the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested