Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test under Python 3.12 #656

Closed
wants to merge 2 commits into from
Closed

ci: Test under Python 3.12 #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9db025
ci: Test under Python 3.12
riddell-stan Feb 23, 2024
7f80151
fix: Remove unsupported openapi spec validation
riddell-stan Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,14 @@ jobs:
include:
- os: ubuntu-22.04
python-version: "3.11"
- os: ubuntu-22.04
python-version: "3.12"
- os: macos-11.0
python-version: "3.10"
- os: macos-11.0
python-version: "3.11"
- os: macos-11.0
python-version: "3.12"
steps:
- name: Check out repository
uses: actions/checkout@v2
Expand All @@ -38,8 +42,10 @@ jobs:
poetry export -f requirements.txt --without-hashes --with dev -o requirements.txt \
&& pip install -r requirements.txt

# disable building docs (included in checks) under Python 3.12, sphinx dependencies do not work
- name: Check code
run: scripts/check
if: ${{ matrix.python-version != 3.12 }}

- name: Build and Install wheel
run: |
Expand Down
2 changes: 1 addition & 1 deletion docs-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ jsonschema>=4.10.0,<4.18.0 # newer versions break sphinxcontrib-openapi
sphinxcontrib-redoc~=1.6

# required for building OpenAPI spec
apispec[yaml,validation]~=4.0
apispec[yaml,validation]~=6.0
marshmallow~=3.10 # needed for apidocs
1 change: 0 additions & 1 deletion httpstan/openapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,4 @@ def openapi_spec() -> apispec.APISpec:
spec.path(path="/v1/models/{model_id}/fits/{fit_id}", view=views.handle_get_fit)
spec.path(path="/v1/models/{model_id}/fits/{fit_id}", view=views.handle_delete_fit)
spec.path(path="/v1/operations/{operation_id}", view=views.handle_get_operation)
apispec.utils.validate_spec(spec)
return spec
Loading