Minimal m1 build #648
Closed
Minimal m1 build #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctures for a couple of python versions.
… architectures for a couple of python versions." This reverts commit cec8321.
- requests more recent poetry version. - maintains existing code checking and tests
…ing. - most recent versions throw errors in some environments -then passes down the dependency tree as each one is fixed - this is a freeeze set of working configuration of dependencies - Note. All related to dev packages only. - Note. Mostly cenetered around Sphinx and api-testing.
|
So no changes to the Makefile or build steps, right? I've created a simpler PR #649 . It doesn't appear to be working at the moment. I'll try to sort out the billing next week. |
|
I recognise those apispec errors, in this pull request I've worked around the sphinx versions by stepping versions backwards. I have another PR here #650 which has the versions stepping forwards and all the existing and the new builds pass. I'll close this PR as the newer is simpler. Correct, no changes to the makefile needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
I've created a minimal changes branch to enable M1 builds using GitHub's recently added M1 runners.
There were a few discoveries a long the way, the GitHub workflow changes here are minimal, there was a lot of time spent discovering a combination of dev dependencies which pass muster on a variety of os & arch combinations. The package solver didn't always get it right wrt what would run, just what would install.
I think this link is public, but let me know if you can't see it;
https://github.com/pdjames/httpstan_build/actions/runs/6530495372
This shows the exact same commit just without the dev dependency changes is failing, in this case it's autoapi that fails, though I have walked up that tree and arrived at what is committed in this PR.
Let me know if you have any questions,
Thanks!
Peter