-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Wiener overloads #780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. (and wow. quite a function!)
Here's the rendered latex, which I'd still appreciate if @Franzi2114 could review |
Thanks @WardBrian!
There are some more spots that have to be changed. This is what I published in the paper that describes the new function: |
Here is my LaTeX code if this helps: Mathematically, the function consists of the reaction times, \begin{equation} where \begin{equation} \begin{equation} where \begin{equation} \begin{equation} Which of these is used in the computations depends on which expression requires the smaller number of components |
Hi @Franzi2114 - There are two difficulties here. One is, to be consistent with our existing documentation, I want to replace the variables in This would be relatively easy for me to find-and-replace, if not for my confusion about your original usages of t0 and \tau -- in particular, I don't know what tau is in your original latex - is it defined anywhere? |
In the latex above, I use \tau_0 as the integration variable. You find this at the end of the integrals: d\tau_0. And \tau_0 ranges from t0 to (t0+st0). |
It's no problem to replace every a with \alpha, t0 with \tau, w with \beta and v with \delta. Also the s_\nu you use above should be a s_\delta. |
Did you shorten the first expression? Two changes are still left:
|
In the first step we havee the 3 integrals to make clear that the 7-parameter density is integrated 3 times, over the three parameters \tau, \beta, \delta. |
Perfect! This looks good ;) |
Is there anything else to do for me? |
Submission Checklist
<<{ since VERSION }>>
Summary
This closes #779 and adds documentation for the functions added in stan-dev/math#2822.
The signatures are fairly straightforward. The preamble which gives the definition of the distribution I adapted from the doxygen comment @Franzi2114 has in the Math documentation. I would appreciate if she could look it over, because I made a few changes (mostly for variable name consistency), and because the original uses$t_0$ , $\tau_0$ , and $t_o$ as variable names, which I think are all what the existing documentation called $\tau$ ?
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: