Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix factor data handling #999

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Fix factor data handling #999

merged 1 commit into from
Jun 15, 2024

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes new errors with passing factor data

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (b271b7b) to head (3d9651e).
Report is 22 commits behind head on master.

Current head 3d9651e differs from pull request most recent head f9fe22e

Please upload reports for the commit f9fe22e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
- Coverage   84.20%   84.05%   -0.15%     
==========================================
  Files          13       13              
  Lines        4793     4849      +56     
==========================================
+ Hits         4036     4076      +40     
- Misses        757      773      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrjohns andrjohns merged commit a45d4f7 into master Jun 15, 2024
11 checks passed
@andrjohns andrjohns deleted the factor-args branch June 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants