Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exported RNG functions respect changes to R's seed #973

Merged
merged 4 commits into from
May 18, 2024

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Exported RNG functions currently manage their state separately from R, so a user calling set.seed() has no effect on the result of the RNG.

This PR updates the exporting of RNG functions to additionally update their seed deterministically from the current seed in R

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@andrjohns andrjohns merged commit b271b7b into master May 18, 2024
11 checks passed
@andrjohns andrjohns deleted the rng-respect-r-seed branch May 18, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant