Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc and tests after latest loo pkg release #923

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Feb 25, 2024

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes a failing test and updates some doc affected by the latest loo package release.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry jgabry changed the title minor updates to doc and tests after latest loo release Update doc and tests after latest loo pkg release Feb 25, 2024
@jgabry jgabry mentioned this pull request Feb 25, 2024
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (d3b455f) to head (1e38769).

❗ Current head 1e38769 differs from pull request most recent head c881c9b. Consider uploading reports for the commit c881c9b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          12       12           
  Lines        4548     4548           
=======================================
  Hits         4017     4017           
  Misses        531      531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgabry
Copy link
Member Author

jgabry commented Feb 25, 2024

Just minor edits to doc and one test, so will go ahead and merge

@jgabry jgabry merged commit 4b94b11 into master Feb 25, 2024
12 checks passed
@jgabry jgabry deleted the loo-updates branch February 25, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants