-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global option for turning off warning for partial initial values #913
Conversation
Looks like the Windows failures are due to issues in the
https://github.com/stan-dev/cmdstanr/actions/runs/7732239038/job/21081730518?pr=913#step:11:16 |
Thanks very much @jgabry -- works perfectly as described above. |
Great, thanks for testing. |
@rok-cesnovar Any idea if this Windows issue is something we need to fix or just some temporary issue that will resolve itself (as is often the case with GitHub actions)? |
Looks like this pacman issue is affecting users too: https://twitter.com/fusaroli/status/1753094135513493693 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #913 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 12 12
Lines 4548 4549 +1
=======================================
+ Hits 4017 4018 +1
Misses 531 531 ☔ View full report in Codecov by Sentry. |
Finally got everything passing here. I think this is a small enough change I could just merge, but will leave open for a bit longer in case @rok-cesnovar or @andrjohns has any issue with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Ok cool will go ahead and merge |
closes #912
Submission Checklist
Summary
Adds a global option to turn off warning about partial initial value specification. When
options(cmdstanr_warn_inits=TRUE)
(the default) the warning message now looks like this, with a new line about disabling the warning:When
options(cmdstanr_warn_inits=FALSE)
there is now no message at all.Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: