Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with v2.34.1 #910

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fix tests with v2.34.1 #910

merged 2 commits into from
Jan 24, 2024

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Updating argument tests to account for changes in stan-dev/cmdstan#1243

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb85ee1) 86.65% compared to head (5f806f7) 86.65%.
Report is 2 commits behind head on master.

❗ Current head 5f806f7 differs from pull request most recent head 0b9d795. Consider uploading reports for the commit 0b9d795 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files          12       12           
  Lines        4534     4534           
=======================================
  Hits         3929     3929           
  Misses        605      605           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrjohns andrjohns merged commit 37b8cd3 into master Jan 24, 2024
12 checks passed
@andrjohns andrjohns deleted the v2.34.1-compat branch January 24, 2024 10:18
@jgabry
Copy link
Member

jgabry commented Jan 24, 2024

Thanks! I was about to look into this today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants