Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show_messages and show_exceptions arguments to all methods #897

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Closes #884 by adding the new show_messages and show_exceptions arguments to all fitting methods

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ae46d3) 88.36% compared to head (e0816e1) 88.37%.

❗ Current head e0816e1 differs from pull request most recent head 00ca320. Consider uploading reports for the commit 00ca320 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #897      +/-   ##
==========================================
+ Coverage   88.36%   88.37%   +0.01%     
==========================================
  Files          12       12              
  Lines        4530     4535       +5     
==========================================
+ Hits         4003     4008       +5     
  Misses        527      527              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@andrjohns andrjohns merged commit d444e7f into master Jan 12, 2024
12 checks passed
@andrjohns andrjohns deleted the show_messages-methods branch January 12, 2024 16:25
@jgabry
Copy link
Member

jgabry commented Jan 16, 2024

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silence output message from optimization
4 participants