Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support/tests for exporting functions with complex types #861

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

We need a very minor tweak to our expose functions routines for supporting complex types (literally 1 line). This PR makes that change and adds tests handling complex types and arrays/tuples

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2023

Codecov Report

Merging #861 (42b0e74) into master (a2af167) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 42b0e74 differs from pull request most recent head ccab663. Consider uploading reports for the commit ccab663 to get more accurate results

@@           Coverage Diff           @@
##           master     #861   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          12       12           
  Lines        4369     4370    +1     
=======================================
+ Hits         3859     3860    +1     
  Misses        510      510           
Files Coverage Δ
R/utils.R 72.79% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrjohns andrjohns merged commit ede72e3 into master Sep 30, 2023
12 checks passed
@jgabry jgabry deleted the complex-support branch September 30, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants