-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the delay behavour in wsl_installed #839
Changed the delay behavour in wsl_installed #839
Conversation
@martinmodrak We should add you as a contributor to CmdStanR! Do you want to add a commit adding yourself to the DESCRIPTION file? Lines 5 to 18 in 8e51a84
|
Thanks for having a look at this @martinmodrak feel free to add yourself as a contributor and then merge! |
I went ahead and added Martin as a contributor and merged master into this branch. We can merge this assuming checks pass (which they should) |
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=======================================
Coverage 88.10% 88.11%
=======================================
Files 12 12
Lines 4212 4215 +3
=======================================
+ Hits 3711 3714 +3
Misses 501 501
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Submission Checklist
Summary
Resolves #838 - at least for me. In
wsl_installed()
, instead of waiting for a fixed period forwsl.exe
to complete, the wait is split into multiple shorter waits, so a) if the call completes quickly, the method returns quickly and b) the total max waiting time is longer (currently 5s).Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Institute of Microbiology of the Czech Academy of Sciences
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: