Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the delay behavour in wsl_installed #839

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

martinmodrak
Copy link
Contributor

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Resolves #838 - at least for me. In wsl_installed(), instead of waiting for a fixed period for wsl.exe to complete, the wait is split into multiple shorter waits, so a) if the call completes quickly, the method returns quickly and b) the total max waiting time is longer (currently 5s).

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Institute of Microbiology of the Czech Academy of Sciences

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@rok-cesnovar rok-cesnovar requested a review from andrjohns August 25, 2023 13:39
@jgabry
Copy link
Member

jgabry commented Aug 25, 2023

@martinmodrak We should add you as a contributor to CmdStanR! Do you want to add a commit adding yourself to the DESCRIPTION file?

cmdstanr/DESCRIPTION

Lines 5 to 18 in 8e51a84

Authors@R:
c(person(given = "Jonah", family = "Gabry", role = c("aut", "cre"),
email = "[email protected]"),
person(given = "Rok", family = "Češnovar", role = "aut",
email = "[email protected]"),
person(given = "Andrew", family = "Johnson", role = "aut",
comment = c(ORCID = "0000-0001-7000-8065")),
person(given = "Ben", family = "Bales", role = "ctb"),
person(given = "Mitzi", family = "Morris", role = "ctb"),
person(given = "Mikhail", family = "Popov", role = "ctb"),
person(given = "Mike", family = "Lawrence", role = "ctb"),
person(given = c("William", "Michael"), family = "Landau", role = "ctb",
email = "[email protected]", comment = c(ORCID = "0000-0003-1878-3253")),
person(given = "Jacob", family = "Socolar", role = "ctb"))

@andrjohns
Copy link
Collaborator

Thanks for having a look at this @martinmodrak feel free to add yourself as a contributor and then merge!

@jgabry
Copy link
Member

jgabry commented Sep 13, 2023

Thanks for having a look at this @martinmodrak feel free to add yourself as a contributor and then merge!

I went ahead and added Martin as a contributor and merged master into this branch. We can merge this assuming checks pass (which they should)

@codecov-commenter
Copy link

Codecov Report

Merging #839 (224ed83) into master (b29374e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 224ed83 differs from pull request most recent head 7daf92b. Consider uploading reports for the commit 7daf92b to get more accurate results

@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   88.10%   88.11%           
=======================================
  Files          12       12           
  Lines        4212     4215    +3     
=======================================
+ Hits         3711     3714    +3     
  Misses        501      501           
Files Changed Coverage Δ
R/utils.R 72.48% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jgabry jgabry merged commit 2911096 into stan-dev:master Sep 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wsl_installed() is not deterministic
4 participants