Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvemements to compile tests #836

Merged

Conversation

martinmodrak
Copy link
Contributor

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Improves tests, resolves #835

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Institute of Microbiology of the Czech Academy of Sciences

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged master in to this and will rerun all the checks. If those pass I think this is good to go.

@codecov-commenter
Copy link

Codecov Report

Merging #836 (52b55fa) into master (b29374e) will increase coverage by 0.14%.
Report is 4 commits behind head on master.
The diff coverage is 67.24%.

❗ Current head 52b55fa differs from pull request most recent head 121abd0. Consider uploading reports for the commit 121abd0 to get more accurate results

@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   88.10%   88.24%   +0.14%     
==========================================
  Files          12       12              
  Lines        4212     4212              
==========================================
+ Hits         3711     3717       +6     
+ Misses        501      495       -6     
Files Changed Coverage Δ
R/model.R 91.78% <67.24%> (+0.39%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rok-cesnovar rok-cesnovar merged commit 22ee5fc into stan-dev:master Sep 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better model compile tests
4 participants