Don't require fixed_param for models with zero parameters (only GQs) for CmdStan >= 2.36
#1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgabry
commented
Nov 25, 2024
| @@ -719,7 +719,7 @@ read_csv_metadata <- function(csv_file) { | |||
| dense_inv_metric <- TRUE | |||
| } else if (inv_metric_next) { | |||
| inv_metric_split <- strsplit(gsub("# ", "", line), ",") | |||
| numeric_inv_metric_split <- rapply(inv_metric_split, as.numeric) | |||
| numeric_inv_metric_split <- suppressWarnings(rapply(inv_metric_split, as.numeric)) | |||
There was a problem hiding this comment.
If the model has no parameters but fixed_param is FALSE this would produce warnings. Simplest thing to do is just suppress.
|
Super simple so going to go ahead and merge this since everything is passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
As of CmdStan 2.36
fixed_paramis not required if the model has no parameters (e.g. only generated quantities).Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: