Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of untar() platform independent in install_cmdstan() #1034

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Nov 14, 2024

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes #1029
Uses @WardBrian suggestion of switching untar's exdir to point to the parent directory, which would allow us to

drop the --strip-components flag entirely, and then it wouldn't matter which tar implementation gets used, including internal. That way the testing/verifying the change is platform independent

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry jgabry changed the title Make use of untar() platform independent in install_cmdstan() Make use of untar() platform independent in install_cmdstan() Nov 14, 2024
@WardBrian
Copy link
Member

@jgabry not sure if you wanted a formal "review" or not since this is so small, but I can confirm this is exactly the change I was imagining

@jgabry
Copy link
Member Author

jgabry commented Nov 15, 2024

Thanks. I think this is good to go then. I don't think we've had anyone test this on older Windows (@yizhang-yiz tested it for me on Windows 11), but it sounds like separately testing on Windows 10 shouldn't be necessary. Or do you think we should find someone running Windows 10 to be extra safe?

@WardBrian
Copy link
Member

Should be fine I think -- if this doesn't work, the bug would be in R's untar, since you're not passing anything bespoke any longer

@jgabry
Copy link
Member Author

jgabry commented Nov 18, 2024

Going to go ahead and merge this since it's passing and has been tested by multiple users.

@jgabry jgabry merged commit bceb482 into master Nov 18, 2024
11 checks passed
@jgabry jgabry deleted the fix-untar-install branch November 18, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Error: install_cmdstan
2 participants