Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stability of r_eff calculation for loo #1015

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jul 30, 2024

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Improve computation of r_eff to better handle very small log-ratios. See stan-dev/loo#272.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry jgabry requested a review from avehtari July 30, 2024 20:34
Copy link
Contributor

@avehtari avehtari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jgabry jgabry merged commit 0e3a99a into master Jul 31, 2024
11 checks passed
@jgabry jgabry deleted the more-stable-r_eff branch July 31, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants