Skip to content

Commit

Permalink
Fix tests with v2.34.1
Browse files Browse the repository at this point in the history
  • Loading branch information
andrjohns committed Jan 24, 2024
1 parent 2abc6ec commit da5b4f6
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions tests/testthat/test-model-optimize.R
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ test_that("optimize() works with (L-)BFGS tolerances specified", {
# using values that aren't the defaults
init_alpha = 0.002,
tol_obj = 2e-11,
tol_rel_obj = 10001,
tol_rel_obj = 1000,
tol_grad = 5e-07,
tol_rel_grad = 10000001,
tol_rel_grad = 1000000,
tol_param = 5e-07,
history_size = 6,
seed = 123
Expand All @@ -128,12 +128,10 @@ test_that("optimize() works with (L-)BFGS tolerances specified", {
metadata <- fit$metadata()
expect_equal(metadata$init_alpha, 0.002)
expect_equal(metadata$tol_obj, 2e-11)
expect_equal(metadata$tol_rel_obj, 10001)
# https://github.com/stan-dev/cmdstan/issues/1242
# expect_equal(metadata$tol_grad, 5e-07)
expect_equal(metadata$tol_rel_grad, 10000001)
# https://github.com/stan-dev/cmdstan/issues/1242
# expect_equal(metadata$tol_param, 5e-07)
expect_equal(metadata$tol_rel_obj, 1000)
expect_equal(metadata$tol_grad, 5e-07)
expect_equal(metadata$tol_rel_grad, 1000000)
expect_equal(metadata$tol_param, 5e-07)
expect_equal(metadata$history_size, 6)
})

Expand Down

0 comments on commit da5b4f6

Please sign in to comment.