Skip to content

Commit

Permalink
Add handling for new rtools version
Browse files Browse the repository at this point in the history
  • Loading branch information
@andrjohns
andrjohns committed Apr 18, 2024
1 parent 1a07f46 commit 4a6dd9d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion R/install.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -855,8 +855,10 @@ rtools4x_version <- function() {
rtools_ver <- "40"
} else if (R.version$minor < "3.0") {
rtools_ver <- "42"
} else {
} else if (R.version$minor < "5.0") {
rtools_ver <- "43"
} else {
rtools_ver <- "44"
}
rtools_ver
}
Expand Down

1 comment on commit 4a6dd9d

@mculbert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should line 858 have R.version$minor < "4.0" instead of 5.0 so that R 4.4 uses rtools_ver == "44" instead of rtools_ver == "43"?

Please sign in to comment.