Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pyproject.toml setup, deduplicate dependencies #735

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

This PR moves all of the metadata for the package out of setup.py and into pyproject.toml. More information is available on the setuptools and python packaging docs :

As part of this, the requirements.txt variants have been removed, but the ability to install those optional dependencies with pip install cmdstanpy[test] etc has been maintained.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian added code cleanup dependencies Pull requests that update a dependency file labels Feb 20, 2024
@WardBrian WardBrian force-pushed the setup/move-to-pyproject branch from 3a21e68 to 0db1a27 Compare February 20, 2024 21:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7e6121) 79.82% compared to head (0db1a27) 79.82%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #735   +/-   ##
========================================
  Coverage    79.82%   79.82%           
========================================
  Files           75       75           
  Lines        11502    11502           
========================================
+ Hits          9181     9182    +1     
+ Misses        2321     2320    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WardBrian WardBrian marked this pull request as ready for review March 6, 2024 14:18
@WardBrian WardBrian requested a review from mitzimorris March 21, 2024 14:46
Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! many thanks!

@WardBrian WardBrian merged commit e0b6477 into develop Mar 21, 2024
16 checks passed
@WardBrian WardBrian deleted the setup/move-to-pyproject branch March 21, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants