Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit maximum number of evaluation points in ppc_pit_ecdf functions by default to 1000. #318

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

TeemuSailynoja
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (07df2ef) 98.52% compared to head (ebb26eb) 98.48%.
Report is 25 commits behind head on master.

❗ Current head ebb26eb differs from pull request most recent head 5bdbccc. Consider uploading reports for the commit 5bdbccc to get more accurate results

Files Patch % Lines
R/ppc-loo.R 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   98.52%   98.48%   -0.04%     
==========================================
  Files          35       35              
  Lines        5006     5019      +13     
==========================================
+ Hits         4932     4943      +11     
- Misses         74       76       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jgabry jgabry merged commit 680b7ae into master Feb 7, 2024
5 of 6 checks passed
@jgabry jgabry deleted the discrete_PIT_in_ppc_pit_ecdf branch February 7, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants