-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrete pit in ppc pit ecdf #316
Conversation
…t_ecdf*() and mcmc_rank_ecdf().
…precomputed values for faster confidence bands.
In case of ECDF (diff) maybe y-axis label should also include be Otherwise, looks good |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 35 35
Lines 5006 5007 +1
=======================================
+ Hits 4932 4933 +1
Misses 74 74 ☔ View full report in Codecov by Sentry. |
Changes to the axis labels are now included in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me
@jgabry this should now be ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TeemuSailynoja!
This PR implements the changes to
ppc_pit_ecdf()
andppc_pit_ecdf_grouped()
mentioned in #315:Additionally, I updated the recommendations for the
K
parameter:And I included some more interpolation values for the confidence bounds into
R/sysdata.rda
. These speed up the plot when using the new default forK
.