Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tokenlists resolver #282
base: master
Are you sure you want to change the base?
feat: tokenlists resolver #282
Changes from all commits
faa9c41
bc0321a
ed233a7
a97a80a
b0b4e86
6b11cd3
9300e3f
2e48ec6
014b9f0
1388001
ad2f62d
c98a1b4
45b03d7
2f6091f
d905720
8e206a3
87cbbf5
527895f
c7da141
58cf1a3
226a3a1
e1697d9
8422fba
dc6aa6b
62180b7
bd130be
743fefd
630644f
ba51a78
6fd9219
8202138
25f3bf2
0b070a4
8521425
c7d2949
9d6ceae
269dbf1
9c1c84c
2e0d09f
edfedb8
0b5a6b3
0ee529e
c0f8a9c
51bff9d
12e86d8
19f2fcb
22892b2
6ea0de3
b90f9fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the
await
here:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the details I tried to clarify but without success. I still feel like my approach of completely decoupling the list updates and the resolver is the better one but I'm not making the decisions here. Please just take from this PR what makes sense to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned here #282 (comment) this is not the expected image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not working due to something unrelated to this PR: the shortname
oeth
is not supported:stamp/src/utils.ts
Lines 50 to 58 in 3b50d97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you'll have to decide what images make most sense to test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests does not need such high timeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Please just take over this branch. I won't make any more changes to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a yarn.lock update, without a dependencies update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk. Maybe because it hasn't been pushed before. Might be my mistake as well. Just delete it and run yarn again.