-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ERC721/ERC1155 resolver #28
base: master
Are you sure you want to change the base?
Conversation
@Sekhmet The 2 examples you share are working well for me. One issue I found is with resizing, when using different width and height it crop the image, for example with this NFT: |
@bonustrack fixed issue with cropping as well with OpenSea ERC1155. |
I think we still need to resize the image to avoid storing too large file and make resizing later faster using the stored original file. The original image resize could work with the same max of 500 but keeping the aspect ratio |
This should be ready, tests are failing due to our Pinata instance not being able to resolve SelfIDs IPFS avatars: Can we do something about it? |
Closes: #25
It adds NFT resolver for ERC721/ERC1155.
One issue I encountered is that OpenSea metadata URL always return 404 for ERC1155s and I'm not sure why - you can check test case for more details.fixed, was due to loss of precision when converting tokenIds.