Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KoreanPhonemizerUtil #989

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Add KoreanPhonemizerUtil #989

merged 6 commits into from
Jan 25, 2024

Conversation

EX3exp
Copy link
Contributor

@EX3exp EX3exp commented Dec 26, 2023

  • Added KoreanPhonemizerUtil.cs, and This class will be used in Diffsinger Korean Phonemizer, other Multiple Korean Phonemizers(including Classic).

  • Implementing Korean Phoneme Variation(like 꽃망울에 to [꼰망우레]), Jamo separation(like 간 to ㄱㅏㄴ), Jamo merge(like ㄱㅏㄴ to 간) in Each phonemizers makes Korean Plugin developers struggle.... So I made KoreanPhonemizerUtil, to increase Productivity and Code re-using.

  • Also supports .ini management, currently used by KO CV Phonemizer & KO ENUNU Phonemizer.

  • If this branch merged, I want to PR two Classic Korean Phonemizers and Diffsinger Korean Phonemizer which using this class. 👀 (+ [23.12.28] Korean ENUNU Phonemizer uses this class too)

This was referenced Dec 26, 2023
@EX3exp EX3exp mentioned this pull request Dec 27, 2023
@oxygen-dioxide
Copy link
Contributor

Why do you add a new ini parser implementation instead of using the existing code in openutau https://github.com/stakira/OpenUtau/blob/master/OpenUtau.Core/Classic/Ini.cs ?

@oxygen-dioxide
Copy link
Contributor

Also if you're adding custom dictionary support, yaml is a better format because it is more extensible, and most other phonemizers use yaml.

@EX3exp EX3exp marked this pull request as draft December 28, 2023 07:00
@EX3exp
Copy link
Contributor Author

EX3exp commented Dec 28, 2023

Why do you add a new ini parser implementation instead of using the existing code in openutau https://github.com/stakira/OpenUtau/blob/master/OpenUtau.Core/Classic/Ini.cs ?

Oh... It was my mistake...😲 I'll fix ini parsing implementation right away. Thanks for mentioning it!

@EX3exp
Copy link
Contributor Author

EX3exp commented Dec 28, 2023

Also if you're adding custom dictionary support, yaml is a better format because it is more extensible, and most other phonemizers use yaml.

I either think .yaml format would be better choice... I'll change dictionary's format into yaml. Thanks for your advice!

@EX3exp
Copy link
Contributor Author

EX3exp commented Dec 28, 2023

I Fixed BaseIniManager's implementation to use OpenUtau's Ini.cs, and now KO ENUNU Phonemizer uses user-customed Jamo dictionary in Yaml format(jamo_dict.yaml). 👀

@EX3exp EX3exp marked this pull request as ready for review December 28, 2023 15:53
@EX3exp EX3exp marked this pull request as draft January 15, 2024 04:36
@EX3exp EX3exp marked this pull request as ready for review January 16, 2024 11:41
@stakira stakira merged commit b18d7b2 into stakira:master Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants