Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "Collection was modified; enumeration operation may not execute." on expression merge #1148

Closed
wants to merge 1 commit into from
Closed

fix "Collection was modified; enumeration operation may not execute." on expression merge #1148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion OpenUtau.Core/Ustx/UProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,16 +97,20 @@ public void MargeExpression(string oldAbbr, string newAbbr) {

void ConvertNoteExp(UNote note, UTrack track) {
if (note.phonemeExpressions.Any(e => e.abbr == oldAbbr)) {
var toRemove = new List<UExpression>();
note.phonemeExpressions.ForEach(oldExp => {
if (!note.phonemeExpressions.Any(newExp => newExp.abbr == newAbbr && newExp.index == oldExp.index)) {
oldExp.abbr = newAbbr;
if (track.TryGetExpDescriptor(this, newAbbr, out var descriptor)) {
oldExp.descriptor = descriptor;
}
} else {
note.phonemeExpressions.Remove(oldExp);
toRemove.Add(oldExp);
}
});
foreach(var exp in toRemove){
note.phonemeExpressions.Remove(exp);
}
}
}
}
Expand Down
Loading