Fix openutau crash when trying to install singer from an encrypted archive file #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this fix, openutau won't crash when trying to install singer from an encrypted archive file. It will show an error dialog.
Encrypted archive isn't supported because the password uses the local encoding of the creator's PC. The archive will be unable to extract by foreign users if the password contains non-ascii characters. We don't encourage the voicebank developers to distribute their voicebank in an encrypted archive file.
related github issue: adamhathcock/sharpcompress#536
related discussion: https://discord.com/channels/551606189386104834/801525671775043625/1162926497988882452