Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved KO DIFFS&KO ENUNU Phonemizer #1120

Merged
merged 2 commits into from
May 10, 2024
Merged

Improved KO DIFFS&KO ENUNU Phonemizer #1120

merged 2 commits into from
May 10, 2024

Conversation

EX3exp
Copy link
Contributor

@EX3exp EX3exp commented Apr 29, 2024

  • Simplified KO DIFFS Phonemizer, Fixed few part of KO ENUNU Phonemizer for compatibility with KoreanPhonemizerUtil.
    Now both phonemizer use same function(RomanizeNotes) when performing Phoneme Variation.
  • [When performing Phoneme Variation] Fixed bug that phoneme turns into empty string ("") when Non-Hanguel string came as lyric.
  • Now KO DIFFS Phonemizer can use dsdict-ko.yaml. (uses dsdict.yaml instead when singer doesn't have dsdict-ko.yaml, as implemented in BaseDiffsingerPhonemizer.)

@EX3exp EX3exp mentioned this pull request Apr 30, 2024
Merged
@stakira stakira merged commit 3742e01 into stakira:master May 10, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EX3exp @stakira