Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN X-SAMPA] Vowel fallback bug fixes #1101

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

lottev1991
Copy link
Contributor

@lottev1991 lottev1991 commented Apr 9, 2024

  • It has come to my attention that I accidentally removed a Teto-specific vowel fallback some time ago (where any instance of V when combined with b will fall back to @). This PR fixes this and re-implements the fallback.
  • Fixed a split diphthong bug.
  • Fixed issue where VV's weren't used in diphthongs.

@lottev1991 lottev1991 marked this pull request as ready for review April 9, 2024 18:09
@SocialReject
Copy link

Will the bugs relating to VVs be fixed too? I've been running into issues while using Peiton and Takoe Zuii English, which both worked perfectly fine on the phonemizer, but up until recently... I've been getting stuff like [eI] and [V] not connecting together the proper way.
image

Peiton does have an [eI V] alias, it's just not being used for some reason. Hope it's okay to tell you here.

@lottev1991
Copy link
Contributor Author

lottev1991 commented Apr 9, 2024

I'm currently fixing those; I did not add that specific code, but I just noticed that today.

@lottev1991 lottev1991 marked this pull request as draft April 9, 2024 20:54
@lottev1991 lottev1991 changed the title [EN X-SAMPA] Vowel fallback bug fix (Teto-related) [EN X-SAMPA] Vowel fallback bug fixex Apr 9, 2024
@lottev1991 lottev1991 changed the title [EN X-SAMPA] Vowel fallback bug fixex [EN X-SAMPA] Vowel fallback bug fixes Apr 9, 2024
@lottev1991 lottev1991 marked this pull request as ready for review April 9, 2024 21:12
@stakira stakira merged commit 26a32e6 into stakira:master Apr 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants