Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleting expressions #1100

Merged
merged 3 commits into from
May 10, 2024
Merged

Fix deleting expressions #1100

merged 3 commits into from
May 10, 2024

Conversation

maiko3tattun
Copy link
Contributor

@maiko3tattun maiko3tattun commented Apr 8, 2024 •
edited
Loading

  • When ustx is loaded, expressions that have been deleted from the project are also deleted from the note (because a null expression descriptor in the note causes an error): UNote
  • Some expressions that was getting directly from the project are now getting via track (Supplement to Add track expression logic #1017)
  • When expressions are deleted in ExpressionsDialog, the default required expressions are added again: ProjectCommand
    Pending as I don't have a solution for duplicate flags.

@maiko3tattun maiko3tattun marked this pull request as draft April 9, 2024 14:48
@maiko3tattun maiko3tattun marked this pull request as ready for review April 21, 2024 11:59
@maiko3tattun
Copy link
Contributor Author

A solution was made in #1118 for when a required expression is deleted in the Expressions dialog.

@stakira stakira merged commit dcd68d5 into stakira:master May 10, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiko3tattun @stakira