Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Draw Pitch Tool #1069

Closed
wants to merge 74 commits into from
Closed

Conversation

maiko3tattun
Copy link
Contributor

@maiko3tattun maiko3tattun commented Mar 19, 2024

The pitch curve is gotten from RenderPhrase, not the note, so that PITD can be drawn correctly with draw pitch tool even if there is vibrato.
image

Merging with #1068 makes it more useful!

@stakira
Copy link
Owner

stakira commented Mar 28, 2024

That was on purpose. If you don't want vibrato, turn it off. On the other hand, you may want to change the overall shape while keeping the vibrato.

@maiko3tattun
Copy link
Contributor Author

maiko3tattun commented Mar 28, 2024

It is disconcerting to have the pitch line drawn away from the mouse cursor.
In addition, it is useful to be able to use the Draw Pitch tool to draw an overwrite when we want to modify a portion of the vibrato and modulation.

@stakira
Copy link
Owner

stakira commented Mar 28, 2024

Could you make it an "alternative tool" like pen-plus?

maiko3tattun and others added 27 commits March 30, 2024 20:22
ENUNUの一部仕様をDiffSingerに合せる
…fering with Path, support for VOICEVOX voice type "sing".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants