Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DiffSinger] Add more mel checks between vocoder and acoustic model #1053

Merged
merged 2 commits into from
Mar 28, 2024
Merged

[DiffSinger] Add more mel checks between vocoder and acoustic model #1053

merged 2 commits into from
Mar 28, 2024

Conversation

yqzhishen
Copy link
Contributor

The following checks are performed between DiffSinger vocoder and acoustic model:

  • sample_rate, hop_size, num_mel_bins, mel_fmin, mel_fmax must be equal
  • mel_scale must be equal and must be slaney or htk
  • mel_base must be 10 or e (mel will be transformed between mismatching values)

@yqzhishen yqzhishen marked this pull request as draft February 26, 2024 16:29
@yqzhishen yqzhishen marked this pull request as ready for review February 27, 2024 06:33
@stakira stakira merged commit e930514 into stakira:master Mar 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yqzhishen @stakira